Update to ScalaCheck 1.13.0 #862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into ScalaTest runtime errors when I tried this for circe, so I'd guess we'll need to wait for a new milestone here as well. |
|
The CI failed because of errors like this: |
|
This could possibly be related to #856, which added a temporary Int => Boolean arbitrary instance. This should be superfluous with the new scalacheck so can probably be removed. I can investigate later, but won't be home for a few hours to do so. |
|
See also scalatest/scalatest#837 |
|
Ok, so updating ScalaCheck is more involved than just updating the version number. Since I currently don't have enough time to work on this, I'll close this PR so that someone else can take over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this locally, so let's see how
Cogenaffects Cats.