Traverse instance for OneAnd #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,8 @@ import scala.util.Random | |||
| class OneAndTests extends CatsSuite { | |||
| checkAll("OneAnd[List, Int]", OrderLaws[OneAnd[List, Int]].eqv) | |||
|
|
|||
| checkAll("OneAnd[List, Int] with Option", TraverseTests[OneAnd[List, ?]].traverse[Int, Int, Int, Int, Option, Option]) | |||
There was a problem hiding this comment.
Can you also add the check the serializability of the Traverse instance as well?
| @@ -13,6 +13,9 @@ import scala.util.Random | |||
| class OneAndTests extends CatsSuite { | |||
| checkAll("OneAnd[List, Int]", OrderLaws[OneAnd[List, Int]].eqv) | |||
|
|
|||
| checkAll("OneAnd[List, Int] with Option", TraverseTests[OneAnd[List, ?]].traverse[Int, Int, Int, Int, Option, Option]) | |||
| checkAll("Functor[OneAnd[List, A]]", SerializableTests.serializable(Traverse[OneAnd[List, ?]])) | |||
There was a problem hiding this comment.
Super minor, but Functor should probably be replaced with Traverse for the name of the Serializable test, to reflect the check being performed.
|
Was very sleepy yesterday. Fixed! |
Current coverage is
|
|
Is there something more I have to do? |
|
👍 |
|
Great. Thanks, @notxcain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Traverseinstance forOneAnd[F, ?]whereF: Traverse