Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Reducible instance for OneAnd, deprecate Foldable instance #772

Merged
merged 3 commits into from
Jan 30, 2016

Conversation

aryairani
Copy link
Contributor

I didn't add a test for oneAndReducible because I couldn't find tests for Reducible. If they're here already, could you point me to them?

Because the new type suggested a name change, I left a Foldable instance in as @deprecated, non-implicit. Let me know if I should do something else.

@codecov-io
Copy link

Current coverage is 88.38%

Merging #772 into master will decrease coverage by -0.13% as of 1f275cc

@@            master    #772   diff @@
======================================
  Files          166     166       
  Stmts         2289    2281     -8
  Branches        74      74       
  Methods          0       0       
======================================
- Hit           2026    2016    -10
  Partial          0       0       
- Missed         263     265     +2

Review entire Coverage Diff as of 1f275cc

Powered by Codecov. Updated on successful CI builds.

@aryairani
Copy link
Contributor Author

Duplicates #757 I guess? Although we probably don't want both Foldable and Reducible instances, since they both require the same Foldable[F] evidence.

@non
Copy link
Contributor

non commented Jan 4, 2016

We don't have to maintain binary compatibility (yet) so let's just remove the foldable instance (since it is subsumed by the reducible one). Thanks!

@ceedubs
Copy link
Contributor

ceedubs commented Jan 6, 2016

👍

As mentioned above, this overlaps with some work done in #757, but I think we want this approach (removing the Foldable instance). We may need to end up breaking #757 down into a couple separate PRs.

mpilquist added a commit that referenced this pull request Jan 30, 2016
add Reducible instance for OneAnd, deprecate Foldable instance
@mpilquist mpilquist merged commit ba77953 into typelevel:master Jan 30, 2016
@mpilquist mpilquist mentioned this pull request Jan 30, 2016
@aryairani aryairani deleted the oneand-reducible branch September 23, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants