Make a bunch of classes final and a few private #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably best to default to `final` and `private` until we run into a reason to expose these for extension.
Current coverage is
|
|
Looks good to me. 👍 |
| implicit def prodApplicative[F[_], G[_]](implicit FF: Applicative[F], GG: Applicative[G]): Applicative[Lambda[X => Prod[F, G, X]]] = new ProdApplicative[F, G] { | ||
| def F: Applicative[F] = FF | ||
| def G: Applicative[G] = GG | ||
| } | ||
| } | ||
|
|
||
| sealed abstract class ProdInstance3 extends ProdInstance4 { | ||
| implicit def prodApply[F[_], G[_]](implicit FF: Apply[F], GG: Apply[G]): Apply[Lambda[X => Prod[F, G, X]]] = new ProdApply[F, G] { | ||
| private[data] sealed abstract class ProdInstance3 extends ProdInstance4 { implicit def prodApply[F[_], G[_]](implicit FF: Apply[F], GG: Apply[G]): Apply[Lambda[X => Prod[F, G, X]]] = new ProdApply[F, G] { |
There was a problem hiding this comment.
Super nitpicky but do you mind re-inserting the line-break here for the sake of consistency and the diff?
There was a problem hiding this comment.
Good catch. I didn't mean to do this.
There was a problem hiding this comment.
Hmm weird. This is on two lines for me locally. Am I hitting some bizarre LF/CR/CRLF inconsistency?
|
👍 from me. |
stew
added a commit
that referenced
this pull request
Nov 15, 2015
Make a bunch of classes final and a few private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably best to default to
finalandprivateuntil we run into areason to expose these for extension.