-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Validated.andThen #611
Conversation
Fixes typelevel#604. This is essentially `flatMap` for `Validated`, but since `flatMap` suggests monadic bind in Cats and this is not consistent with `ap`, another name is being used.
Current coverage is
|
|
👍 I'm okay with |
👍 I would be fine with In the context of |
It sounds like people are generally okay with I'll move forward with documentation. |
I added some documentation. @adelbertc I deleted part of your I think there's still room for improvement, so please feel free to chime in. |
LGTM 👍 |
Fixes #604.
This is essentially
flatMap
forValidated
, but sinceflatMap
suggests monadic bind in Cats and this is not consistent with
ap
,another name is being used.
This PR is not complete yet. I need to add a Scaladoc comment and tut documentation about this change. However, I figured there might be some discussion about the name of the method, so I want to wait until a name is decided to start writing docs :). Is
andThen
too overloaded?