XorT.toOption returns an OptionT

[ceedubs]

This makes toOption on XorT[F, A, B] return OptionT[F, B] instead
of F[Option[B]]. This makes it symmetrical with toRight and toLeft
on OptionT. My assumption here is that if you are working with XorT
instead of F[Xor...] that you would also prefer to work with OptionT
rather than F[Option[...]]. And if not, it's easy enough to call
.value.

[codecov-io]

Current coverage is 76.29%

Merging #610 into master will not affect coverage as of 06ea4e6

@@            master    #610   diff @@
======================================
  Files          160     160       
  Stmts         2194    2194       
  Branches        68      68       
  Methods          0       0       
======================================
  Hit           1674    1674       
  Partial          0       0       
  Missed         520     520       

Review entire Coverage Diff as of 06ea4e6

Powered by Codecov. Updated on successful CI builds.

[frosforever]

I am super on board with this. There's yet to be a time where I didn't want OptionT from XorT.
Would it make sense to name it explicitly toOptionT instead?

[ceedubs]

@frosforever I considered toOptionT. The reason I didn't go forward with it was that then it seemed like toRight and toLeft on OptionT should be named something else. And toRightT didn't quite seem right. I'm definitely open to suggestions here.

[adelbertc]

👍 from me

[frosforever]

@ceedubs fair enough, that would be a mess. The types should make it clear what it's returning anyway.

[mpilquist]

👍