Streaming.take(n).toList shouldn't blow up when n+1 is an error #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
| case Cons(a, lt) => Cons(a, lt.map(_.take(n - 1))) | ||
| case Cons(a, lt) => | ||
| if (n == 1) Cons(a, Now(Empty())) | ||
| else Cons(a, lt.map(_.take(n - 1))) |
There was a problem hiding this comment.
Maybe I'm too fussy, but could we rewrite that line?
Cons(a, if (n == 1) Now(Empty()) else lt.map(_.take(n - 1))
|
👍 (with-or-without my fussy suggestion honestly) |
A gift for @non.
|
👍 |
|
Merge conflicts. Also one nitpicky comment :-) |
| @@ -473,7 +473,8 @@ sealed abstract class Streaming[A] { lhs => | |||
| if (n <= 0) Empty() else this match { | |||
| case Empty() => Empty() | |||
| case Wait(lt) => Wait(lt.map(_.take(n))) | |||
| case Cons(a, lt) => Cons(a, lt.map(_.take(n - 1))) | |||
| case Cons(a, lt) => | |||
| Cons(a, if (n ==1) Now(Empty()) else lt.map(_.take(n - 1))) | |||
There was a problem hiding this comment.
Eeeek, space between == and 1 :-)
|
@adelbertc thanks. Hopefully this should pass inspection now :) |
|
👍 |
1 similar comment
|
👍 |
adelbertc
added a commit
that referenced
this pull request
Sep 15, 2015
Streaming.take(n).toList shouldn't blow up when n+1 is an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cons(a, lt.map(_.take(n - 1)))seems reasonable enough, but sincetoListcallslt.value, this blows up whenltis a deferred error.