Skip to content

Return Xor instead of Either in Free.resume #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
non merged 1 commit into from
Sep 8, 2015
Merged

Return Xor instead of Either in Free.resume #518

non merged 1 commit into from
Sep 8, 2015

Conversation

@ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Sep 8, 2015

This makes it consistent with conventions used elsewhere in Cats.

@ceedubs
Return Xor instead of Either in Free.resume
425e634 
This makes it consistent with conventions used elsewhere in Cats.
@non
Copy link
Contributor

non commented Sep 8, 2015

Makes sense to me.

👍 when Travis passes.

@mpilquist
Copy link
Member

mpilquist commented Sep 8, 2015

👍

@codecov-io
Copy link

codecov-io commented Sep 8, 2015

Current coverage is 63.79%

Merging #518 into master will not affect coverage as of 3324d6d

@@            master    #518   diff @@
======================================
  Files          154     154       
  Stmts         2359    2359       
  Branches        66      66       
  Methods          0       0       
======================================
  Hit           1505    1505       
  Partial          0       0       
  Missed         854     854

Review entire Coverage Diff as of 3324d6d

Powered by Codecov. Updated on successful CI builds.

non added a commit that referenced this pull request Sep 8, 2015
@non
Merge pull request #518 from ceedubs/free-resume-xor
2455ca0 
Return Xor instead of Either in Free.resume
@non non merged commit 2455ca0 into typelevel:master Sep 8, 2015
@non non removed the in progress label Sep 8, 2015
@ceedubs ceedubs deleted the free-resume-xor branch November 15, 2015 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ceedubs @non @mpilquist @codecov-io