Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example using foldMap on to a tuple #517

Merged
merged 1 commit into from
Sep 3, 2015

Conversation

philwills
Copy link
Contributor

This is based on feedback from @adelbertc to a previous PR.

I've also changed 'typeclass' to 'type class'.

@codecov-io
Copy link

Current coverage is 63.79%

Merging #517 into master will not affect coverage as of 504c8e8

@@            master    #517   diff @@
======================================
  Files          154     154       
  Stmts         2359    2359       
  Branches        66      66       
  Methods          0       0       
======================================
  Hit           1505    1505       
  Partial          0       0       
  Missed         854     854       

Review entire Coverage Diff as of 504c8e8

Powered by Codecov. Updated on successful CI builds.

@adelbertc
Copy link
Contributor

Hurrah! We currently don't have Monoid instances for TupleN (we need to fix that..) but until then this LGTM 👍

Following https://github.com/non/cats/blob/3c2c516676d6db733b08ee9d00396df52b90e94a/PROCESS.md#merging-pull-requests I'm merging this

adelbertc added a commit that referenced this pull request Sep 3, 2015
Add an example using foldMap on to a tuple
@adelbertc adelbertc merged commit 672e010 into typelevel:master Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants