Add Kleisli.fromFunction, WriterT.liftFunctionK #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
reviewed
Oct 22, 2020
| * res0: Option[String] = Some(42) | ||
| * }}} | ||
| */ | ||
| def fromFunction[M[_]: Applicative, A, R](f: R => A): Kleisli[M, R, A] = |
There was a problem hiding this comment.
Is this a candidate for some partial application tomfoolery so we might be able to say Kleisli.fromFunction[Option] and infer the R and A?
There was a problem hiding this comment.
it's a good idea, I will give it a closer look
There was a problem hiding this comment.
I guess we can't infer R anyway unless there's a type annotation for the whole thing. Probably the best we can do is Kleisli.fromFunction[Option, Int] and inferring the result.
barambani
reviewed
Oct 30, 2020
|
@rossabaker when you have time, I'd appreciate another look :) |
LukaJCB
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.