Avoid all evaluation of LazyList#foldRightDefer #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayahilton
force-pushed
the
avoid-all-evaluation-ll
branch
from
1949bb4
to
830d301
Compare
|
One of the CI failures is just a connectivity thing and the other seems definitely unrelated (see #3568), so I just restarted both jobs. |
travisbrown
reviewed
Aug 14, 2020
| @@ -52,6 +55,16 @@ class LazyListSuite extends CatsSuite { | |||
| assert(LazyList.empty[Int].show === (s"LazyList()")) | |||
| } | |||
|
|
|||
| test("Avoid all evaluation of LazyList#foldRightDefer") { | |||
There was a problem hiding this comment.
Just to confirm: this test hangs without the change above?
There was a problem hiding this comment.
Yes, The test never finishes.
|
One Scala.js build is still failing even after a couple of restarts. It couldn't be related, so I think we can just wait and try again in a couple of hours or so. |
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
+ Coverage 91.28% 91.29% +0.01%
==========================================
Files 386 386
Lines 8605 8606 +1
Branches 246 260 +14
==========================================
+ Hits 7855 7857 +2
+ Misses 750 749 -1 |
|
It seems it was a corrupted cache. I deleted the PR's cache and it went through. |
barambani
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.