Comments on NonEmptyReducible not being a typeclass #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NonEmptyReducible` is not a typeclass and should not be used outside of Cats. Thus, the corresponding comments are added to the `NonEmptyReducible` along with `catsDataInstancesForNonEmptyVector` and `catsDataInstancesForNonEmptyList` implementing it.
|
👍 but I think the "should not be used outside of Cats" might not be a universal opinion. |
Codecov Report
@@ Coverage Diff @@
## master #3562 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 386 386
Lines 8587 8587
Branches 235 235
=======================================
Hits 7837 7837
Misses 750 750 |
LukaJCB
approved these changes
Aug 11, 2020
kailuowang
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NonEmptyReducibleis not a typeclass and should not be used outside of Cats. Thus, the corresponding comments are added to theNonEmptyReduciblealong withcatsDataInstancesForNonEmptyVectorandcatsDataInstancesForNonEmptyListimplementing it.