Order for writert #3556
Merged
Order for writert #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependent on #3555 |
Codecov Report
@@ Coverage Diff @@
## master #3556 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 386 386
Lines 8577 8580 +3
Branches 240 234 -6
=======================================
+ Hits 7830 7833 +3
Misses 747 747 |
TimWSpence
force-pushed
the
order-for-writert
branch
2 times, most recently
from
523d446
to
d792220
Compare
TimWSpence
force-pushed
the
order-for-writert
branch
from
d792220
to
eacd388
Compare
This is now merged so this PR should be ready for review :) |
djspiewak
approved these changes
Aug 12, 2020
Comment on lines
+324
to
+325
| def compare(that: WriterT[F, L, V])(implicit Ord: Order[F[(L, V)]]): Int = | ||
| Ord.compare(run, that.run) |
There was a problem hiding this comment.
Is this a normal thing to add directly to the type? I actually don't know what our idiom is here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.