Remove traverseForEither in Traverse companion object #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsrh
approved these changes
Jul 29, 2020
|
Seems like this was introduced here: 56d94da#diff-dfc66c84b778099ad28a81e9b0ece505 @travisbrown I'm assuming this was a mistake, but maybe there was some motivation I'm unaware of? |
Codecov Report
@@ Coverage Diff @@
## master #3540 +/- ##
==========================================
- Coverage 91.34% 91.33% -0.01%
==========================================
Files 386 386
Lines 8592 8591 -1
Branches 269 251 -18
==========================================
- Hits 7848 7847 -1
Misses 744 744 |
barambani
approved these changes
Jul 29, 2020
Closed
|
I guess it's pretty safe to merge this in. |
|
Hmm, just saw this PR, but yes, looks like a mistake to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure how this got here, but it's messing up things in dotty 0.25 so we should get rid of it asap.