make collection traversals stack safe #3521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3517
This makes all the traversals of all collections stack safe.
It follows the approach of: typelevel/fs2#1957 but it is lazier (and maybe a bit slower because of that).
Cats has some tests that traversals on Applicatives that have lazy map2Eval instances that it won't trigger the function in those cases, so these laws require the traverse not only to have a certain result, but also invoke a function a known number of times.
I added tests before making each change and showed that the collection would fail a certain traversal (using Function0 as an example monad with poor stack safety).