remove some casts in AndThen #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3518 +/- ##
==========================================
- Coverage 91.54% 91.52% -0.02%
==========================================
Files 386 386
Lines 8476 8462 -14
Branches 245 216 -29
==========================================
- Hits 7759 7745 -14
Misses 717 717 |
barambani
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before scala 2.12, you could not use
tailrecwith generics that changed types as the recursion went on. But now, we only support 2.12 and later.That pattern is used in a few places in cats. This PR removes those casts and shortens the code in AndThen.
It helps see that the code is safe and should be just as fast.