Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more implementations to Function0 and Function1 Monads #3515

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Add some more implementations to Function0 and Function1 Monads #3515

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aa4f79
Add some more implementations to Function0 and Function1 Monads
johnynek Jul 11, 2020
24c6cd4
fix dotty compilation
johnynek Jul 12, 2020
9185231
address review comments
johnynek Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/scala/cats/instances/function.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ sealed private[instances] trait Function0Instances extends Function0Instances0 {
() => (fa(), fb())

override def ap[A, B](f: () => A => B)(fa: () => A): () => B =
() => f().apply(fa())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was that .apply here in the first place? does () => f()(fa()) work on dotty, maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it starts to look like a soup of parens, so I didn't write it that way.

() => {
val fnAB = f()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write this as either f.apply.apply(fa()) or f()(fa()) on Dotty, both of which are I think a little nicer than the extra val.

fnAB(fa())
}

def flatMap[A, B](fa: () => A)(f: A => () => B): () => B =
() => f(fa())()
Expand Down