-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Scalafmt 2.6.0 #3476
Merged
Merged
Update to Scalafmt 2.6.0 #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 when ready. |
travisbrown
force-pushed
the
topic/scalafmt-2.6.0
branch
from
June 17, 2020 19:54
464d523
to
06ce859
Compare
Okay, new Simulacrum Scalafix release is out and this is ready for review! @barambani, I've included the single-line comment unfolding config. |
Codecov Report
@@ Coverage Diff @@
## master #3476 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 383 383
Lines 8394 8394
Branches 204 215 +11
=======================================
Hits 7704 7704
Misses 690 690 |
LukaJCB
approved these changes
Jun 17, 2020
barambani
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
rossabaker
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix this problem, and relies on this (currently unreleased) change in Simulacrum Scalafix. Note that the Scalafmt change itself is relatively small (464d523).
If people agree that this looks reasonable, I'll publish a Simulacrum Scalafix 0.4.0 release and remove the "Draft" marker here.[Done.]