Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Scalafmt 2.6.0 #3476

Merged
merged 6 commits into from
Jun 18, 2020
Merged

Update to Scalafmt 2.6.0 #3476

merged 6 commits into from
Jun 18, 2020

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented Jun 17, 2020

This is an attempt to fix this problem, and relies on this (currently unreleased) change in Simulacrum Scalafix. Note that the Scalafmt change itself is relatively small (464d523).

If people agree that this looks reasonable, I'll publish a Simulacrum Scalafix 0.4.0 release and remove the "Draft" marker here. [Done.]

@barambani
Copy link
Contributor

👍 when ready.

@travisbrown travisbrown marked this pull request as ready for review June 17, 2020 20:20
@travisbrown
Copy link
Contributor Author

Okay, new Simulacrum Scalafix release is out and this is ready for review! @barambani, I've included the single-line comment unfolding config.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #3476 into master will not change coverage.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##           master    #3476   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         383      383           
  Lines        8394     8394           
  Branches      204      215   +11     
=======================================
  Hits         7704     7704           
  Misses        690      690           

Copy link
Contributor

@barambani barambani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@travisbrown travisbrown merged commit 7c07f71 into master Jun 18, 2020
@travisbrown travisbrown deleted the topic/scalafmt-2.6.0 branch June 18, 2020 03:59
@travisbrown travisbrown added this to the 2.2.0-RC1 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants