Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scalafmt to 2.5.2 #3425

Merged
merged 2 commits into from
May 30, 2020
Merged

Update Scalafmt to 2.5.2 #3425

merged 2 commits into from
May 30, 2020

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented May 24, 2020

Like #3409 but includes the formatting changes. I've changed one thing besides the version in the configuration: I removed RedundantBraces, since it was resulting in a lot of bare nested if expressions that I thought hurt readability. This gets us a little closer to the defaults, anyway.

Note: if we don't remove RedundantBraces, the diff is even larger:

 283 files changed, 4108 insertions(+), 3472 deletions(-)

So this both gets us closer to the current default and keeps us closer to our old formatting.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #3425 into master will increase coverage by 0.00%.
The diff coverage is 82.83%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3425   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         381      381           
  Lines        8268     8271    +3     
  Branches      227      227           
=======================================
+ Hits         7577     7580    +3     
  Misses        691      691           
Flag Coverage Δ
#scala_version_212 91.63% <82.83%> (+<0.01%) ⬆️
#scala_version_213 91.43% <82.32%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...lleycats-core/src/main/scala/alleycats/ConsK.scala 0.00% <0.00%> (ø)
...lleycats-core/src/main/scala/alleycats/Empty.scala 0.00% <0.00%> (ø)
...leycats-core/src/main/scala/alleycats/EmptyK.scala 0.00% <0.00%> (ø)
...eycats-core/src/main/scala/alleycats/Extract.scala 0.00% <0.00%> (ø)
alleycats-core/src/main/scala/alleycats/One.scala 0.00% <0.00%> (ø)
alleycats-core/src/main/scala/alleycats/Pure.scala 0.00% <0.00%> (ø)
alleycats-core/src/main/scala/alleycats/Zero.scala 0.00% <0.00%> (ø)
...la/alleycats/laws/discipline/FlatMapRecTests.scala 100.00% <ø> (ø)
.../main/scala-2.13+/cats/data/NonEmptyLazyList.scala 79.46% <ø> (ø)
core/src/main/scala/cats/Alternative.scala 70.58% <0.00%> (ø)
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f27f07...b99a854. Read the comment docs.

@travisbrown travisbrown requested a review from fthomas May 27, 2020 12:01
@mpilquist mpilquist merged commit fdb5723 into master May 30, 2020
@travisbrown travisbrown added this to the 2.2.0-M3 milestone May 31, 2020
@larsrh larsrh deleted the update/scalafmt-2.5.2 branch September 19, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants