Remove cats.instances from tests #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossabaker
approved these changes
Apr 1, 2020
fthomas
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I kind of messed up in #3043. I'd originally removed (almost) all use of
cats.instancesin the tests by getting rid of both imports and the instance traits, but then a few weeks ago we merged #3304, which replaced the instance traits with imports, and I didn't include the import removal in the final rebase. That's what I get for having PRs open for six months. 😄This isn't a big deal—it just means the tests need the change in this PR in order to actually exercise the implicit scope instances. There is one instance that's missing (
AlignforStream), but I'll add that in a follow-up, to keep this PR tests-only.