Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3126 Remove Order constraint from Hash instance for SortedSet #3339

Merged

Conversation

gagandeepkalra
Copy link
Contributor

addresses #3143

@gagandeepkalra
Copy link
Contributor Author

learned a lot of Scala with this one 😌

@codecov-io
Copy link

codecov-io commented Mar 1, 2020

Codecov Report

Merging #3339 into scala_2.11 will decrease coverage by 0.03%.
The diff coverage is 42.85%.

Impacted file tree graph

@@              Coverage Diff               @@
##           scala_2.11    #3339      +/-   ##
==============================================
- Coverage       93.46%   93.42%   -0.04%     
==============================================
  Files             385      385              
  Lines            7162     7165       +3     
  Branches          197      191       -6     
==============================================
  Hits             6694     6694              
- Misses            468      471       +3
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/sortedSet.scala 85.71% <25%> (-2.53%) ⬇️
...ala/cats/kernel/instances/SortedSetInstances.scala 91.66% <66.66%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29efba5...b047aaa. Read the comment docs.

@travisbrown travisbrown self-requested a review March 2, 2020 07:58
Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@gagandeepkalra gagandeepkalra changed the title Backported #3126 Remove Order constraint from Hash instance for SortedSet Backport #3126 Remove Order constraint from Hash instance for SortedSet Mar 8, 2020
@travisbrown travisbrown merged commit 8227961 into typelevel:scala_2.11 Mar 10, 2020
@gagandeepkalra gagandeepkalra deleted the backport/hash/sortedSet branch March 10, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants