Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArraySeq instance follow-up #3302

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

travisbrown
Copy link
Contributor

This builds on #3273, addressing #2994. It adds a few instances that were missing and makes the cats-kernel prioritization traits package-private.

@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #3302 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3302      +/-   ##
==========================================
+ Coverage   93.15%   93.15%   +<.01%     
==========================================
  Files         378      378              
  Lines        7579     7585       +6     
  Branches      203      204       +1     
==========================================
+ Hits         7060     7066       +6     
  Misses        519      519
Flag Coverage Δ
#scala_version_212 93.38% <ø> (-0.02%) ⬇️
#scala_version_213 92.93% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
....13+/cats/kernel/instances/ArraySeqInstances.scala 100% <ø> (ø) ⬆️
...src/main/scala-2.13+/cats/instances/arraySeq.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e24fc...1e65c60. Read the comment docs.

@travisbrown travisbrown added this to the 2.2.0-M1 milestone Feb 18, 2020
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukaJCB
Copy link
Member

LukaJCB commented Feb 18, 2020

Doesn't have to be this PR, but we could add a TraverseFilter instance as well. :)
Happy to merge this as is though.

@travisbrown
Copy link
Contributor Author

@LukaJCB @BalmungSan already got TraverseFilter in #3273! 😄

@travisbrown travisbrown merged commit 8126941 into typelevel:master Feb 18, 2020
@travisbrown travisbrown deleted the topic/follow-up-3273 branch February 18, 2020 16:52
jorgeadriano pushed a commit to jorgeadriano/cats that referenced this pull request Feb 20, 2020
* Add Align, CoflatMap, and Alternative instances for ArraySeq

* Avoid ArraySeq prioritization traits in public API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants