Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traverseEither #3294

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Add traverseEither #3294

merged 1 commit into from
Feb 14, 2020

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Feb 13, 2020

I find this combinator really useful, as it doesn't discard information in the way traverseFilter does.

@codecov-io
Copy link

Codecov Report

Merging #3294 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3294      +/-   ##
==========================================
+ Coverage   93.14%   93.15%   +<.01%     
==========================================
  Files         378      378              
  Lines        7575     7579       +4     
  Branches      194      203       +9     
==========================================
+ Hits         7056     7060       +4     
  Misses        519      519
Flag Coverage Δ
#scala_version_212 93.4% <100%> (ø) ⬆️
#scala_version_213 92.93% <100%> (ø) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/TraverseFilter.scala 100% <100%> (ø) ⬆️
...ala/cats/laws/discipline/TraverseFilterTests.scala 100% <100%> (ø) ⬆️
.../src/main/scala/cats/laws/TraverseFilterLaws.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ced57...9a21c5f. Read the comment docs.

Copy link
Contributor

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@travisbrown travisbrown merged commit 28143e7 into master Feb 14, 2020
@LukaJCB LukaJCB deleted the traverse-either branch February 14, 2020 15:52
@travisbrown travisbrown added this to the 2.2.0-M1 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants