Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotty cross-building [WIP] #3269

Closed

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented Jan 24, 2020

This is a work-in-progress pull request that should pass CI but is missing or waiting on several things:

Note that while this PR looks like a big change—currently +2,662 -297—over 2,400 of the added lines have been automatically generated by Scalafix rules, and another hundred or so are just moving the FunctionK.lift macro into version-specific code. There aren't much more than a hundred lines of substantive changes.

I've been opening Dotty bug reports for issues that I've had to work around. Some of these have already been fixed, and it's likely that more will be resolved by the time this PR is ready to merge:

I'm opening this for tracking and discussion now that -Ykind-projector is in the Dotty nightly releases, but we probably won't be in a position to merge it for a while, and I'll be rebasing and force-pushing to keep it updated.

I have a similar branch for cats-effect, but haven't opened a PR there yet (update: WIP cats-effect PR is open).

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #3269 into master will decrease coverage by 1.15%.
The diff coverage is 64.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3269      +/-   ##
==========================================
- Coverage   93.31%   92.15%   -1.16%     
==========================================
  Files         378      378              
  Lines        7684     7932     +248     
  Branches      233      206      -27     
==========================================
+ Hits         7170     7310     +140     
- Misses        514      622     +108
Flag Coverage Δ
#scala_version_212 92.18% <64.1%> (-1.21%) ⬇️
#scala_version_213 91.94% <64.87%> (-1.15%) ⬇️
Impacted Files Coverage Δ
...rc/main/scala/cats/laws/NonEmptyTraverseLaws.scala 85% <ø> (ø) ⬆️
core/src/main/scala/cats/CommutativeMonad.scala 0% <0%> (ø) ⬆️
core/src/main/scala/cats/CommutativeApply.scala 50% <0%> (-16.67%) ⬇️
core/src/main/scala/cats/Monad.scala 81.25% <0%> (-15.05%) ⬇️
core/src/main/scala/cats/Distributive.scala 50% <0%> (-16.67%) ⬇️
core/src/main/scala/cats/CommutativeFlatMap.scala 0% <0%> (ø) ⬆️
...e/src/main/scala/cats/CommutativeApplicative.scala 60% <0%> (-15%) ⬇️
...lleycats-core/src/main/scala/alleycats/ConsK.scala 0% <0%> (ø) ⬆️
...eycats-core/src/main/scala/alleycats/Extract.scala 0% <0%> (ø) ⬆️
alleycats-core/src/main/scala/alleycats/Pure.scala 0% <0%> (ø) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469f1eb...593c05d. Read the comment docs.

@larsrh
Copy link
Contributor

larsrh commented Jul 27, 2020

Obsoleted by #3486

@larsrh larsrh closed this Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants