-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotty cross-building [WIP] #3269
Closed
travisbrown
wants to merge
32
commits into
typelevel:master
from
travisbrown:topic/dotty-cross-build
Closed
Dotty cross-building [WIP] #3269
travisbrown
wants to merge
32
commits into
typelevel:master
from
travisbrown:topic/dotty-cross-build
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3269 +/- ##
==========================================
- Coverage 93.31% 92.15% -1.16%
==========================================
Files 378 378
Lines 7684 7932 +248
Branches 233 206 -27
==========================================
+ Hits 7170 7310 +140
- Misses 514 622 +108
Continue to review full report at Codecov.
|
travisbrown
force-pushed
the
topic/dotty-cross-build
branch
from
January 24, 2020 15:09
4b7f15c
to
76293db
Compare
4 tasks
travisbrown
force-pushed
the
topic/dotty-cross-build
branch
from
February 26, 2020 13:44
6fb5ac1
to
73812bb
Compare
travisbrown
force-pushed
the
topic/dotty-cross-build
branch
from
February 26, 2020 15:08
73812bb
to
593c05d
Compare
This was referenced May 22, 2020
Obsoleted by #3486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress pull request that should pass CI but is missing or waiting on several things:
Note that while this PR looks like a big change—currently
+2,662 -297
—over 2,400 of the added lines have been automatically generated by Scalafix rules, and another hundred or so are just moving theFunctionK.lift
macro into version-specific code. There aren't much more than a hundred lines of substantive changes.I've been opening Dotty bug reports for issues that I've had to work around. Some of these have already been fixed, and it's likely that more will be resolved by the time this PR is ready to merge:
I'm opening this for tracking and discussion now that
-Ykind-projector
is in the Dotty nightly releases, but we probably won't be in a position to merge it for a while, and I'll be rebasing and force-pushing to keep it updated.I have a similar branch for cats-effect, but haven't opened a PR there yet (update: WIP cats-effect PR is open).