Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Developer-Comment regarding an unused parameter. #3224

Merged
merged 1 commit into from
Dec 22, 2019
Merged

Add a Developer-Comment regarding an unused parameter. #3224

merged 1 commit into from
Dec 22, 2019

Conversation

diesalbla
Copy link
Contributor

Just adds a comment, regarding an unused implicit parameter.

With a link to https://github.com/typelevel/cats/pull/1867/files#r138381991.

@codecov-io
Copy link

codecov-io commented Dec 21, 2019

Codecov Report

Merging #3224 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3224      +/-   ##
==========================================
- Coverage   93.05%   93.03%   -0.02%     
==========================================
  Files         376      376              
  Lines        7412     7412              
  Branches      192      192              
==========================================
- Hits         6897     6896       -1     
- Misses        515      516       +1
Flag Coverage Δ
#scala_version_212 93.36% <ø> (+0.01%) ⬆️
#scala_version_213 92.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Validated.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyList.scala 98.06% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c8121...cf1b1f0. Read the comment docs.

LukaJCB
LukaJCB previously approved these changes Dec 21, 2019
@LukaJCB LukaJCB merged commit 424f10a into typelevel:master Dec 22, 2019
@travisbrown travisbrown added this to the 2.2.0-M1 milestone Jan 14, 2020
@diesalbla diesalbla deleted the add_comment_unused_parameter branch June 20, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants