Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant final modifiers on objects #3183

Merged

Conversation

travisbrown
Copy link
Contributor

Similar to #3182. Dotty is complaining about these finals on objects and they're unnecessary on Scala 2.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #3183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         376      376           
  Lines        7381     7381           
  Branches      195      195           
=======================================
  Hits         6864     6864           
  Misses        517      517
Flag Coverage Δ
#scala_version_212 93.32% <ø> (ø) ⬆️
#scala_version_213 90.59% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Chain.scala 98.43% <ø> (ø) ⬆️
kernel/src/main/scala/cats/kernel/Comparison.scala 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ff6fe...5934f4f. Read the comment docs.

@travisbrown travisbrown merged commit 31b82ba into typelevel:master Dec 3, 2019
@travisbrown travisbrown added this to the 2.1.0-RC3 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants