Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Iterable instances implementation. #3174

Merged

Conversation

takayahilton
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #3174 into master will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
+ Coverage   92.99%   93.34%   +0.35%     
==========================================
  Files         376      372       -4     
  Lines        7381     7203     -178     
  Branches      195      187       -8     
==========================================
- Hits         6864     6724     -140     
+ Misses        517      479      -38
Flag Coverage Δ
#scala_version_212 93.34% <100%> (+0.02%) ⬆️
#scala_version_213 ?
Impacted Files Coverage Δ
...s-core/src/main/scala/alleycats/std/iterable.scala 100% <100%> (+25%) ⬆️
...in/scala/cats/data/AbstractNonEmptyInstances.scala 96.55% <0%> (-3.45%) ⬇️
...e/src/main/scala-2.13+/cats/data/ZipLazyList.scala
...src/main/scala-2.13+/cats/instances/lazyList.scala
....13+/cats/kernel/instances/LazyListInstances.scala
.../main/scala-2.13+/cats/data/NonEmptyLazyList.scala

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2084a2a...6379598. Read the comment docs.

@travisbrown travisbrown self-requested a review December 10, 2019 14:03
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kailuowang kailuowang merged commit f651c2b into typelevel:master Dec 10, 2019
@travisbrown travisbrown added this to the 2.1.0-RC3 milestone Dec 10, 2019
@takayahilton takayahilton deleted the optimize-iterable-implementions branch December 10, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants