Add catchOnly to ApplicativeError. #3165
Conversation
takayahilton
force-pushed
the
add-catchOnly-monad-error
branch
from
8153a8c
to
240241e
Compare
takayahilton
force-pushed
the
add-catchOnly-monad-error
branch
from
240241e
to
6d04326
Compare
Codecov Report
@@ Coverage Diff @@
## master #3165 +/- ##
==========================================
- Coverage 93.04% 92.99% -0.05%
==========================================
Files 376 376
Lines 7374 7381 +7
Branches 209 195 -14
==========================================
+ Hits 6861 6864 +3
- Misses 513 517 +4
Continue to review full report at Codecov.
|
|
Looks reasonable to me. |
| // this is a somewhat bogus test: | ||
| res should not be (null) | ||
| } | ||
| } |
There was a problem hiding this comment.
Might it be useful to also test that catchOnly on an unrelated exception does not catch?
| def catchOnly[T >: Null <: Throwable]: CatchOnlyPartiallyApplied[T, F, E] = | ||
| new CatchOnlyPartiallyApplied[T, F, E](this) |
There was a problem hiding this comment.
Out of curiosity... I'm struggling to understand this.
What was the T >: Null constraint added for in there? To me it seems that due to the latter constraint T <: Throwable the former one will be always satisfied automatically, won't it? This is because Throwable is AnyRef and Null <: T <: AnyRef for any T.
Or am I missing something?
@takayahilton could you clarify please?
No description provided.