Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 1.x deprecation targets package-private #3154

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

travisbrown
Copy link
Contributor

This PR makes everything that was deprecated in 1.x package-private (in the cases where that's possible without breaking bincompat).

This means less noise in the API docs, and that users will be in a better position to be ready once we can finally clean this stuff up for real.

I don't feel terribly strongly about getting this into 2.1.0, but I think it'd be nice to have.

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #3154 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3154      +/-   ##
==========================================
- Coverage   93.15%   93.11%   -0.05%     
==========================================
  Files         376      376              
  Lines        7353     7353              
  Branches      204      190      -14     
==========================================
- Hits         6850     6847       -3     
- Misses        503      506       +3
Flag Coverage Δ
#scala_version_212 93.45% <0%> (-0.05%) ⬇️
#scala_version_213 90.77% <0%> (-0.06%) ⬇️
Impacted Files Coverage Δ
core/src/main/scala/cats/data/NonEmptyList.scala 98.7% <ø> (-0.65%) ⬇️
core/src/main/scala/cats/data/Kleisli.scala 90.9% <ø> (ø) ⬆️
core/src/main/scala/cats/package.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/semigroupal.scala 50% <ø> (ø) ⬆️
free/src/main/scala/cats/free/Trampoline.scala 0% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/apply.scala 57.14% <ø> (ø) ⬆️
free/src/main/scala/cats/free/Coyoneda.scala 84.61% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/duration.scala 66.66% <ø> (-33.34%) ⬇️
core/src/main/scala/cats/Apply.scala 78.94% <ø> (ø) ⬆️
...src/main/scala/cats/instances/finiteDuration.scala 0% <ø> (-100%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3eed57...d52979c. Read the comment docs.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm often surprised from how far back people are upgrading, and usually err on the side of keeping deprecations around a long time, but these are implicits or pre-1.x. An out-of-character 👍 from me.

@travisbrown
Copy link
Contributor Author

@rossabaker Out-of-character 👍s are the best 👍s. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants