Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more doctest to WriterT #3073

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

hamednourhani
Copy link
Contributor

Re: Issue #2479

Add more doctest to WriterT methods:

  • tell
  • written
  • value
  • listen
  • ap
  • map
  • imap
  • mapK
  • flatMap
  • mapBoth
  • bimap
  • mapWritten
  • swap
  • reset
  • show
  • foldLeft
  • foldRight
  • traverse

@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #3073 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3073   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         368      368           
  Lines        6979     6979           
  Branches      184      184           
=======================================
  Hits         6523     6523           
  Misses        456      456
Impacted Files Coverage Δ
core/src/main/scala/cats/data/WriterT.scala 91.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c138a50...158f6dd. Read the comment docs.

@hamednourhani
Copy link
Contributor Author

Hi @kailuowang would you please review this PR.

@hamednourhani
Copy link
Contributor Author

@scala-steward would you please review this PR

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamednourhani
Copy link
Contributor Author

Hi @kailuowang thanks for approving prs. I have some approved pull requests on #2479. Will thay be merged in the next release

@larsrh larsrh merged commit ed77f8e into typelevel:master Oct 5, 2019
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants