Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move appropriate SortedSet and SortedMap instances to kernel #3001

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

travisbrown
Copy link
Contributor

I'm splitting out some of the less controversial parts of #3000 so they're not blocked by the name fixes (which I still think should happen before 3.0, even if not in 2.0).

These instances for SortedMap and SortedSet clearly belong in cats-kernel, and while there's some overhead involved in moving them and maintaining bincompat, in this case I think it's hard to argue that it's not worth it—this isn't fixing typos, it's making import cats.kernel.instances.all._ do the obviously correct thing.

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #3001 into master will decrease coverage by 0.14%.
The diff coverage is 85.48%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3001      +/-   ##
=========================================
- Coverage   93.75%   93.6%   -0.15%     
=========================================
  Files         366     368       +2     
  Lines        6935    6948      +13     
  Branches      185     188       +3     
=========================================
+ Hits         6502    6504       +2     
- Misses        433     444      +11
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/sortedMap.scala 84.74% <0%> (-12.76%) ⬇️
...ala/cats/kernel/instances/SortedSetInstances.scala 100% <100%> (ø)
...ala/cats/kernel/instances/SortedMapInstances.scala 100% <100%> (ø)
core/src/main/scala/cats/instances/sortedSet.scala 88.23% <42.85%> (-11.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd7283...a7713e8. Read the comment docs.

@travisbrown travisbrown mentioned this pull request Aug 23, 2019
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I still hope that we could avoid the bincompat traits by waiting for the branch, but not strongly.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Travis.

@LukaJCB LukaJCB merged commit a7373fe into typelevel:master Aug 23, 2019
@travisbrown travisbrown added this to the 2.0-RC2 milestone Aug 26, 2019
xuwei-k added a commit to scala-steward/Monocle that referenced this pull request Aug 27, 2019
xuwei-k pushed a commit to optics-dev/Monocle that referenced this pull request Aug 27, 2019
* Update alleycats-core, cats-core, cats-free, ... to 2.0.0-RC2

* add cats sortedMap instance import

typelevel/cats#3001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants