Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize chain's get. #2999

Merged
merged 3 commits into from
Aug 22, 2019
Merged

optimize chain's get. #2999

merged 3 commits into from
Aug 22, 2019

Conversation

takayahilton
Copy link
Contributor

No description provided.

@kailuowang
Copy link
Contributor

kailuowang commented Aug 22, 2019 •
edited
Loading

I know get is tested by Foldable laws but since now we added a get to the class, should we add a test here as well? something like forAll(c: Chain, i: Int) => c.get(i) shouldBe c.toList.lift(i)?

This is the same CI error seen in #2983 , you can either change the jdk as done there or wait for that PR to be merged and merge master back to this one.

@takayahilton
Copy link
Contributor Author

Thanks!
Fixed.

@kailuowang kailuowang merged commit 6db5193 into typelevel:master Aug 22, 2019
@takayahilton takayahilton deleted the optimize-chain-get branch August 22, 2019 14:51
@travisbrown travisbrown added this to the 2.0-RC2 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0-RC2
Development

Successfully merging this pull request may close these issues.
4 participants
@takayahilton @kailuowang @LukaJCB @travisbrown