Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain optimize map method #2995

Merged

Conversation

gagandeepkalra
Copy link
Contributor

fixes #2959

@codecov-io
Copy link

Codecov Report

Merging #2995 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         369      369              
  Lines        7072     7073       +1     
  Branches      195      190       -5     
==========================================
+ Hits         6636     6637       +1     
  Misses        436      436
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Chain.scala 99.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241a7b9...649b160. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2995 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
+ Coverage   93.83%   93.83%   +<.01%     
==========================================
  Files         369      369              
  Lines        7072     7073       +1     
  Branches      195      190       -5     
==========================================
+ Hits         6636     6637       +1     
  Misses        436      436
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Chain.scala 99.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241a7b9...649b160. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LukaJCB LukaJCB merged commit a97bb9a into typelevel:master Aug 20, 2019
@gagandeepkalra gagandeepkalra deleted the chain/optimizeMapImplementation branch August 20, 2019 05:41
@travisbrown travisbrown added this to the 2.0-RC2 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain.map seems not optimized
5 participants