Add Hash instance for NonEmptySet. #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2981 +/- ##
==========================================
+ Coverage 93.83% 93.83% +<.01%
==========================================
Files 369 369
Lines 7068 7069 +1
Branches 187 193 +6
==========================================
+ Hits 6632 6633 +1
Misses 436 436
Continue to review full report at Codecov.
|
kailuowang
suggested changes
Aug 9, 2019
| implicit def catsDataEqForNonEmptySet[A](implicit A: Order[A]): Eq[NonEmptySet[A]] = new NonEmptySetEq[A] { | ||
| implicit override def A0: Eq[A] = A | ||
| } | ||
| } | ||
|
|
||
| sealed abstract private[data] class NonEmptySetInstances1 { | ||
| implicit def catsDataHashForNonEmptySet[A: Order: Hash]: Hash[NonEmptySet[A]] = | ||
| Hash[SortedSet[A]].asInstanceOf[Hash[NonEmptySet[A]]] |
There was a problem hiding this comment.
Hash inherits Eq and thus should swap positions with it.
LukaJCB
approved these changes
Aug 9, 2019
kailuowang
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.