Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala 2.12 to 2.12.9 #2978

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Conversation

jhnsmth
Copy link
Contributor

@jhnsmth jhnsmth commented Aug 6, 2019

No description provided.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@jhnsmth
Copy link
Contributor Author

jhnsmth commented Aug 6, 2019

CI failure seems unrelated...

@jhnsmth jhnsmth closed this Aug 6, 2019
@jhnsmth jhnsmth reopened this Aug 6, 2019
@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #2978 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2978   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         369      369           
  Lines        7067     7067           
  Branches      195      195           
=======================================
  Hits         6632     6632           
  Misses        435      435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d76cbb...41c4811. Read the comment docs.

@kailuowang
Copy link
Contributor

hi, @jhnsmth thanks for the PR.
BTW, you didn't have to close and reopen the PR to trigger the CI build. Maintainers can rerun the single failed job.

@takayahilton
Copy link
Contributor

scala/bug#11665
we should wait until the release of 2.12.10 ?

@djspiewak
Copy link
Member

@takayahilton Not sure that bug is relevant to cats, given that we don't really use string interpolation very much. It's possible though.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string interp bug also won't be passed transitively to our users, as might happen in a regular dependency.

@LukaJCB LukaJCB merged commit f05a16a into typelevel:master Aug 6, 2019
@travisbrown travisbrown added this to the 2.0-RC2 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants