Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax to option. #2969

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Conversation

takayahilton
Copy link
Contributor

  • Add toRightNel
  • Add toRightNec
  • Add toLeftNel
  • Add toLeftNec

These are useful when used with Parallel.

- Add `toRightNel`
- Add `toRightNec`
- Add `toLeftNel`
- Add `toLeftNec`
LukaJCB
LukaJCB previously approved these changes Aug 1, 2019
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

tpolecat
tpolecat previously approved these changes Aug 1, 2019
@takayahilton takayahilton dismissed stale reviews from tpolecat and LukaJCB via ab7c657 August 1, 2019 17:02
@codecov-io
Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #2969 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +<.01%     
==========================================
  Files         371      371              
  Lines        7061     7065       +4     
  Branches      177      178       +1     
==========================================
+ Hits         6633     6637       +4     
  Misses        428      428
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/option.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bab9eb...62f0695. Read the comment docs.

@kailuowang kailuowang merged commit 06ea761 into typelevel:master Aug 2, 2019
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
@takayahilton takayahilton deleted the add-syntax-to-option branch August 2, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants