Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader contravariant on input type A #2922

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Reader contravariant on input type A #2922

merged 1 commit into from
Jun 28, 2019

Conversation

kklorenzotesta
Copy link
Contributor

Kleisli is contravariant on A from #2843 , so Reader and ReaderT should also be contravariant in A.

@codecov-io
Copy link

Codecov Report

Merging #2922 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2922   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files         367      367           
  Lines        7002     7002           
  Branches      195      195           
=======================================
  Hits         6599     6599           
  Misses        403      403
Impacted Files Coverage Δ
core/src/main/scala/cats/data/package.scala 90.9% <ø> (ø) ⬆️
core/src/main/scala/cats/data/Kleisli.scala 90.99% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2371a...4668057. Read the comment docs.

@kailuowang kailuowang merged commit 8387863 into typelevel:master Jun 28, 2019
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants