Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 2.13.0-RC2 #2857

Merged
merged 5 commits into from
May 25, 2019
Merged

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented May 24, 2019

Depends on a new Discipline release with this change and Machinist but otherwise I think this is ready to go.

@kailuowang
Copy link
Contributor

thanks to #2858 by @dotta, merging in master should probably fix the build here

@travisbrown
Copy link
Contributor Author

We’ll still need Machinist and Discipline releases but thanks!

@travisbrown
Copy link
Contributor Author

Just confirmed that +buildJVM is fine here with the current Discipline master locally published as 0.12.0 (thanks for the Machinist release, @larsrh).

@larsrh
Copy link
Contributor

larsrh commented May 25, 2019

I've fixed the Discipline build number. Now, waiting for tut.

@larsrh
Copy link
Contributor

larsrh commented May 25, 2019

tpolecat/tut#250

@travisbrown
Copy link
Contributor Author

Thanks @larsrh! I’m going to be away from the computer until next Wednesday so anyone should feel free to grab these commits or whatever.

@codecov-io
Copy link

codecov-io commented May 25, 2019

Codecov Report

Merging #2857 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2857   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         368      368           
  Lines        6948     6948           
  Branches      307      308    +1     
=======================================
  Hits         6546     6546           
  Misses        402      402
Impacted Files Coverage Δ
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2b6ff...f1f34b0. Read the comment docs.

@larsrh
Copy link
Contributor

larsrh commented May 25, 2019

Turns out we don't necessarily need tut because CI runs it only on 2.12.

@larsrh larsrh changed the title Updates for 2.13.0-RC2 [WIP] Updates for 2.13.0-RC2 May 25, 2019
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang
Copy link
Contributor

I am out of town this weekend. If no one beats me, I can cut a cats 2.0m2 release Tuesday

@travisbrown
Copy link
Contributor Author

Excellent, thanks all!

@rossabaker
Copy link
Member

I'm around tonight. Is releasing still the state of the art?

@larsrh larsrh merged commit c0095a2 into typelevel:master May 25, 2019
@kailuowang kailuowang added this to the 2.0.0-M2 milestone Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants