Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2708 sorted set semigroupal #2840

Merged
merged 4 commits into from
May 21, 2019
Merged

2708 sorted set semigroupal #2840

merged 4 commits into from
May 21, 2019

Conversation

vhutov
Copy link
Contributor

@vhutov vhutov commented May 11, 2019

#2708
I also added missed instances for the sortedmap object

@vhutov vhutov mentioned this pull request May 11, 2019
Closed
@codecov-io
Copy link

codecov-io commented May 11, 2019 •
edited
Loading

Codecov Report

Merging #2840 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
+ Coverage   94.21%   94.21%   +<.01%     
==========================================
  Files         368      368              
  Lines        6944     6948       +4     
  Branches      301      303       +2     
==========================================
+ Hits         6542     6546       +4     
  Misses        402      402
Impacted Files Coverage Δ
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/sortedSet.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912a14a...e9c61ce. Read the comment docs.

LukaJCB
LukaJCB approved these changes May 11, 2019
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, looks very good, thanks! :)

kailuowang
kailuowang approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@kailuowang kailuowang merged commit 6e5b979 into typelevel:master May 21, 2019
@vhutov vhutov deleted the 2708-sorted-set-semigroupal branch May 21, 2019 15:35
@rossabaker rossabaker mentioned this pull request May 26, 2019
Merged
@kailuowang kailuowang added this to the 2.0.0-M2 milestone Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0-M2
Development

Successfully merging this pull request may close these issues.
4 participants
@vhutov @codecov-io @kailuowang @LukaJCB