make stage more explicit

[kailuowang]

This also results in a very short lint stage and a longer test stage, which was my original intention.

[codecov-io]

Codecov Report

Merging #2828 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2828   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         370      370           
  Lines        7038     7038           
  Branches      186      186           
=======================================
  Hits         6618     6618           
  Misses        420      420

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d29f7b...794b3c2. Read the comment docs.

[rossabaker]

What runs scalastyle now?

[kailuowang]

@rossabaker, my bad. Forgot to mention that I removed it since scalafmt is much more strict, scalastyle keeps failing on parsing from time to time. Not sure if we need to maintain two sets of styling rules.

[rossabaker]

In that case, validateJVM still calls it. If we're not going to enforce it on the build, we should also remove it from there. It's also still mentioned in CONTRIBUTING.md.

We could even go a step further and remove the config and the plugin, unless we think it's still providing some marginal value when run manually.

[kailuowang]

@rossabaker good point. I will udpate this PR with complete scalastyle removal.

[kailuowang]

@rossabaker scalastyle was removed in another PR and merged. This one is good to go right?

[rossabaker]

👍