Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added FreeT basic example #2819

Merged
merged 2 commits into from
May 21, 2019
Merged

added FreeT basic example #2819

merged 2 commits into from
May 21, 2019

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Apr 28, 2019

@codecov-io
Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #2819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2819   +/-   ##
=======================================
  Coverage   94.15%   94.15%           
=======================================
  Files         368      368           
  Lines        6914     6914           
  Branches      296      296           
=======================================
  Hits         6510     6510           
  Misses        404      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b6b32...2087995. Read the comment docs.

} yield a + b + c


/* Our interpreters e.g. for Future, DBIO, Id */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say let's not use Future in our documentation. Just don't want to give people the impression that it's not a bad idea to use Future. For the purpose of your example, we could use Either or something

Copy link
Contributor Author

@mtsokol mtsokol Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up with Try instead of Future.

You have mentioned adding FAQ item about moving away from Future.
So e.g. short paragraph about crucial reasons providing some sources for further reading?
Something like cats effect docs comparison?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the jobs has failed somehow with "GC overhead limit exceeded" and I'm not able to rerun it. Could you rerun it? Or should I trigger it (e.g. close and open pull)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the last response. Yeah, that cats effect docs is great as a further reading!

@kailuowang kailuowang requested a review from LukaJCB May 21, 2019 15:17
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing :)

@kailuowang kailuowang merged commit 00f07bf into typelevel:master May 21, 2019
@kailuowang kailuowang added this to the 2.0.0-M2 milestone Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants