-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added FreeT basic example #2819
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 368 368
Lines 6914 6914
Branches 296 296
=======================================
Hits 6510 6510
Misses 404 404 Continue to review full report at Codecov.
|
} yield a + b + c | ||
|
||
|
||
/* Our interpreters e.g. for Future, DBIO, Id */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say let's not use Future
in our documentation. Just don't want to give people the impression that it's not a bad idea to use Future
. For the purpose of your example, we could use Either
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up with Try
instead of Future
.
You have mentioned adding FAQ item about moving away from Future
.
So e.g. short paragraph about crucial reasons providing some sources for further reading?
Something like cats effect docs comparison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the jobs has failed somehow with "GC overhead limit exceeded" and I'm not able to rerun it. Could you rerun it? Or should I trigger it (e.g. close and open pull)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the last response. Yeah, that cats effect docs is great as a further reading!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing :)
#2818