Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonoidK instances for Map and SortedMap #2744

Merged

Conversation

alexeygorobets
Copy link
Contributor

solve #2714

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #2744 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2744      +/-   ##
==========================================
+ Coverage    95.3%   95.33%   +0.03%     
==========================================
  Files         363      363              
  Lines        6771     6777       +6     
  Branches      291      299       +8     
==========================================
+ Hits         6453     6461       +8     
+ Misses        318      316       -2
Impacted Files Coverage Δ
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <ø> (ø) ⬆️
core/src/main/scala/cats/instances/map.scala 95.12% <100%> (+0.38%) ⬆️
core/src/main/scala/cats/instances/sortedMap.scala 97.5% <100%> (+0.09%) ⬆️
...rc/main/scala/cats/kernel/instances/function.scala 100% <0%> (+3.03%) ⬆️
testkit/src/main/scala/cats/tests/Helpers.scala 100% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e248dcc...b4ab2b9. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great addition! :)

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants