Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instructions for checking binary compatibility #2656

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

bplommer
Copy link
Contributor

@bplommer bplommer commented Dec 3, 2018

Adds a missing character to instructions for checking binary compatibility.

@bplommer bplommer changed the title instructions for checking binary compatibility Fix instructions for checking binary compatibility Dec 3, 2018
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks @bplommer!

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@codecov-io
Copy link

codecov-io commented Dec 3, 2018

Codecov Report

Merging #2656 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2656   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         363      363           
  Lines        6704     6704           
  Branches      289      305   +16     
=======================================
  Hits         6377     6377           
  Misses        327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bea999...fa757e7. Read the comment docs.

@ceedubs ceedubs merged commit 72582ad into typelevel:master Dec 3, 2018
@kailuowang kailuowang added this to the 1.6 milestone Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants