Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to glossary. #2636

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Some changes to glossary. #2636

merged 2 commits into from
Dec 3, 2018

Conversation

diesalbla
Copy link
Contributor

We move details to bottom, correct some typos, and add some missing methods, specially
in the Foldable type class.

@diesalbla diesalbla changed the title Some changes to the glossary. Some changes to glossary. Nov 21, 2018
We move the details to the bottom. We correct some typos.
We add some methods missed in the first pass, specially
in the `Foldable` type class.
@codecov-io
Copy link

codecov-io commented Nov 22, 2018

Codecov Report

Merging #2636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2636   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         363      363           
  Lines        6704     6704           
  Branches      305      305           
=======================================
  Hits         6377     6377           
  Misses        327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfbc22...4acb45c. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ceedubs
Copy link
Contributor

ceedubs commented Dec 3, 2018

Thanks @diesalbla! Sorry, but there's a merge conflict. Would you mind resolving that?

@kailuowang
Copy link
Contributor

that was an easy conflict I resolved

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@LukaJCB LukaJCB merged commit 7392a43 into typelevel:master Dec 3, 2018
@kailuowang kailuowang added this to the 1.6 milestone Jan 8, 2019
@diesalbla diesalbla deleted the nomenclature_more branch January 19, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants