-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type signature of productL
in cats glossary
#2625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Oh, doh, I think I misunderstood the instructions about |
Just to confirm |
@mtomko sorry the instruction wasn't clear. |
I mentioned some other possible changes to the nomenclature file in gitter, which I'm happy to add to this PR. I'll summarize them here. If you want me to add them let me know and I'll include them in separate commits: First, in the signature for Secondly, the word |
Got it, thanks for the information! |
Codecov Report
@@ Coverage Diff @@
## master #2625 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 363 363
Lines 6704 6704
Branches 305 289 -16
=======================================
Hits 6377 6377
Misses 327 327 Continue to review full report at Codecov.
|
I made the other changes in a separate PR: #2642 |
Thank you for contributing to Cats!
This is a kind reminder to run
sbt prePR
and commit the changed files before submitting.