Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateWith method to NonEmptyMap #2592

Merged
merged 7 commits into from
Nov 6, 2018

Conversation

nasadorian
Copy link
Contributor

@nasadorian nasadorian commented Nov 2, 2018

  • Named updateWith since updated would imply a simple setting of k -> v
  • Added a couple small tests

Closes #2288

@nasadorian
Copy link
Contributor Author

nasadorian commented Nov 2, 2018

Build is flaky? Seems to have died with OOM for Scala 2.13...

@codecov-io
Copy link

codecov-io commented Nov 2, 2018

Codecov Report

Merging #2592 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
+ Coverage   95.16%   95.16%   +<.01%     
==========================================
  Files         361      361              
  Lines        6634     6637       +3     
  Branches      294      290       -4     
==========================================
+ Hits         6313     6316       +3     
  Misses        321      321
Impacted Files Coverage Δ
...ore/src/main/scala/cats/data/NonEmptyMapImpl.scala 96.15% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aac375...4e1ea7d. Read the comment docs.

kubukoz
kubukoz previously approved these changes Nov 2, 2018
@kubukoz
Copy link
Member

kubukoz commented Nov 2, 2018

Can you add Closes #2288 to the description? It'll close the issue automatically once this is merged.

@ceedubs
Copy link
Contributor

ceedubs commented Nov 2, 2018

Thanks @nasadorian!

This looks good to me, but I don't think that the tests are hitting the case where the key isn't in the map. Could you explicitly test that case? It could probably be a unit test and/or an sbt-doctest example.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, @nasadorian!

@kailuowang kailuowang merged commit fe9a6e7 into typelevel:master Nov 6, 2018
@kailuowang kailuowang added this to the 1.5 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants