Remove duplicate menu item in docs #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also change Monad menu item to directly link to monad page
Codecov Report
@@ Coverage Diff @@
## master #2574 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 361 361
Lines 6630 6630
Branches 289 283 -6
=======================================
Hits 6308 6308
Misses 322 322Continue to review full report at Codecov.
|
|
sorry about the delay. I think your proposal makes sense. |
kailuowang
approved these changes
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that in the documentation, there seems to be duplicate sub-menu items for Functors and Applicatives, under both
Traversable FunctorsandMonads.When you click on either sub-menu items, they show the exact same page and highlight both items on the side menu. It seems to make more sense to remove
FunctorsandApplicativesfrom the Monads menu, since Monads appear right afterTraversable Functorsanyways.Let me know if this is something that has already been raised before, or it is this way for a reason. I was just initially confused because I noticed that 2 menu items would be lit up when I visited these pages.