Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Duration Instances to cats.instances.all and cats.implicits #2515

Merged
merged 2 commits into from
Sep 28, 2018

Conversation

LukaJCB
Copy link
Member

@LukaJCB LukaJCB commented Sep 19, 2018

Fixes #2216

kailuowang
kailuowang previously approved these changes Sep 19, 2018
kailuowang
kailuowang previously approved these changes Sep 19, 2018
@kailuowang kailuowang added this to the 1.5 milestone Sep 19, 2018
easel
easel previously approved these changes Sep 25, 2018
Copy link
Contributor

@easel easel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukaJCB LukaJCB dismissed stale reviews from easel and kailuowang via a231814 September 27, 2018 09:11
@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #2515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2515   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files         360      360           
  Lines        6549     6549           
  Branches      275      278    +3     
=======================================
  Hits         6234     6234           
  Misses        315      315
Impacted Files Coverage Δ
testkit/src/main/scala/cats/tests/CatsSuite.scala 70% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4acdbb9...a231814. Read the comment docs.

@LukaJCB LukaJCB merged commit 6cd6104 into typelevel:master Sep 28, 2018
@LukaJCB LukaJCB deleted the duration branch September 28, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants