Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-pgp to 1.1.2 #2495

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

scala-steward
Copy link
Contributor

Update com.jsuereth:sbt-pgp from 1.1.0 to 1.1.2.

@djspiewak
Copy link
Member

Perhaps not the right place for the discussion, but I would strongly consider using sbt-gpg instead of sbt-pgp. It's considerably simpler and more stable, offering much better compatibility with modern versions of GPG. Since we aren't publishing releases on CI, nothing should need to actually change in the build infrastructure, just swapping out the plugin and removing some of the old settings that were required to make sbt-pgp work.

fthomas
fthomas previously approved these changes Sep 18, 2018
@codecov-io
Copy link

codecov-io commented Sep 18, 2018

Codecov Report

Merging #2495 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2495      +/-   ##
==========================================
+ Coverage   95.35%   95.38%   +0.02%     
==========================================
  Files         358      358              
  Lines        6530     6605      +75     
  Branches      282      285       +3     
==========================================
+ Hits         6227     6300      +73     
- Misses        303      305       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/eq.scala 0% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Validated.scala 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5a51a...b128803. Read the comment docs.

Copy link
Contributor

@easel easel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to stay up to date, but I'm not one signing packages so a little tough to say the change is impact free

@kailuowang kailuowang merged commit 161cb63 into typelevel:master Sep 25, 2018
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants