-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sbt-pgp to 1.1.2 #2495
Update sbt-pgp to 1.1.2 #2495
Conversation
e4fec0d
to
4ec9c0a
Compare
Perhaps not the right place for the discussion, but I would strongly consider using sbt-gpg instead of sbt-pgp. It's considerably simpler and more stable, offering much better compatibility with modern versions of GPG. Since we aren't publishing releases on CI, nothing should need to actually change in the build infrastructure, just swapping out the plugin and removing some of the old settings that were required to make sbt-pgp work. |
4ec9c0a
to
38cc1e9
Compare
38cc1e9
to
fc67aa3
Compare
Codecov Report
@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
+ Coverage 95.35% 95.38% +0.02%
==========================================
Files 358 358
Lines 6530 6605 +75
Branches 282 285 +3
==========================================
+ Hits 6227 6300 +73
- Misses 303 305 +2
Continue to review full report at Codecov.
|
fc67aa3
to
b128803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to stay up to date, but I'm not one signing packages so a little tough to say the change is impact free
Update com.jsuereth:sbt-pgp from 1.1.0 to 1.1.2.