-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to Functor and verify with docstyle #2483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Nit: the indentation changed (from scaladoc convention to javadoc)
@kailuowang Sorry about that, I assumed that we'd have a default scalafmt conf :) |
484dcbd
to
ddb27a0
Compare
ddb27a0
to
8a5bff7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
- Coverage 95.38% 95.35% -0.04%
==========================================
Files 357 357
Lines 6517 6517
Branches 279 282 +3
==========================================
- Hits 6216 6214 -2
- Misses 301 303 +2
Continue to review full report at Codecov.
|
@kailuowang LMK if there are any remaining issues with the indentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
Thanks Yuval! :) |
This PR implements #2479 for the
Functor
typeclass.Would love feedback on the examples, if anything more complex is needed.